Parameter Lock Sample Assignment is not copied #5
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: mark/elk-herd#5
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Firstly, thank you so much for making this tool, it has really helped me with managing projects and combining them to make a 'set', etc.
Doing this I found a couple of niggly bugs that made it a bit awkward, but not insurmountable.
TL;DR - it doesn't select the samples assigned for Parameter Locks (P-Locks) correctly when importing and if you combine two projects with P-Locks, the sample numbering for the trigs with locks points at the wrong place (original sample slot).
As an example, there are 3 projects in the attached archive.
Digitakt_Exports.zip
The first 2 are created on the Digitakt:
Copy_Locks_Bug.syx - contains a simple drum beat with the factory kit on Bank 1, Pattern 1, Track 1 with Sample 1 as the default assignment. Trigs 5 & 13 are P-Lock'd to Sample 2 and Trig 15 to Sample 7. (I reassigned the default samples for Tracks 2-8 to Sample 9-15 to 'move' these samples out of the way and cleared all but the used 3 samples out of Ram)
Sample_Num Bug.syx - contains a simple riff with a factory sound on Bank 1, Pattern 1, Track 1, with Sample 1 containing the default for the track - 'Acidic' synth sound - and then Trig 15 is assigned to another sound (Sample 2 'Frog')
Combined_Projects.syx - a new project with the sample Ram cleared, then I imported the above 2 projects assigning 1 to Bank 1 and 2 to Bank 2. If you play Bank 2, Pattern 1, you will notice Trig 15 on Track 1 points to Sample 2 (it should point to Sample 17 - 'Frog')
Method:
Create a project, create a pattern on one or more tracks using P-Locks for some of the Trigs
Fetch the project in Elk Herd and save it to computer.
Repeat.
Create an empty project on the Digitakt and clear the Ram (to make it easier to see what's going on. Personally, I imported on top of another project I had fetched when I discovered the bug.
Fetch the empty project.
Import one of your projects from disk - NOTE: the samples assigned to P-Lock'd Trigs are not selected by default - select them!
Import another project from disk - NOTE it puts the 2nd project's samples at the next available slots in the pool.
Put the 2nd project in Bank 2
Send the project to the Digitakt.
Play the second bank - NOTE that when it plays the P-Lock'd Trigs, the sound will be from the originally assigned slot in the old project, it won't point at the new one.
Workaround:
Combine all your projects and send to the Digitakt.
Go to the first bank which has P-Locks that don't point to the correct sound.
Open the project file in Elk-Herd to see the sample pool and use as a guide to select the sample based on the old numbering / offset from the default P-Lock.
(Hard work, but this only happened on tracks where I was layering lots of different drum sounds to save space for all my other samples)
I've found the bug! I'll be pushing a fix today or tomorrow.
I've pushed the fix as a beta:
https://electric.kitchen/crunch/elk-herd/beta/
Amazing!! I will try to test over this weekend :)
Yay, dude, I think you fixed it!!
I tested with those 2 projects and imported them again into a new project and everything was intakt 😁
I also tried with one of my more complicated projects - loaded it up, extracted it from a set and imported it into a new project with all the locks / sample numbers nicely there too!
Thanks so much for this, it's going to be really helpful for moving my sets and projects around!
Wonderful - I'll mark this bug fixed once I've moved this to release.
Nice. Sent you a beer!
closed in v3.3.4